Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused associated type from ShieldedUtils #1670

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

batconjurer
Copy link
Member

This type was an attempt to reduce the number of generic parameters needed when interacting with MASP but resulted in making code re-use extremely difficult.

@batconjurer batconjurer requested review from grarco and murisi July 5, 2023 15:59
apps/src/lib/client/rpc.rs Outdated Show resolved Hide resolved
@batconjurer batconjurer requested a review from grarco July 6, 2023 08:25
grarco
grarco previously approved these changes Jul 6, 2023
Copy link
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@murisi murisi requested a review from mateuszjasiuk July 6, 2023 11:11
@murisi
Copy link
Collaborator

murisi commented Jul 6, 2023

@mateuszjasiuk Would you be able to review this since it impacts the MASP web interface? Thanks!

mateuszjasiuk
mateuszjasiuk previously approved these changes Jul 6, 2023
Copy link
Contributor

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in the interface, we just need to remove 2 lines

@tzemanovic tzemanovic dismissed stale reviews from mateuszjasiuk and grarco via a22eacb July 12, 2023 07:19
tzemanovic added a commit that referenced this pull request Jul 13, 2023
* bat/remove-unused-assoc-ty:
  changelog: add #1670
  [chore]: Removed unnecessary  trait bounds
  [feat]: Removed unused associated type from ShieldedUtils
@tzemanovic tzemanovic mentioned this pull request Jul 13, 2023
@Fraccaman Fraccaman merged commit bd9b857 into main Jul 22, 2023
@Fraccaman Fraccaman deleted the bat/remove-unused-assoc-ty branch July 22, 2023 11:41
Fraccaman added a commit that referenced this pull request Jul 25, 2023
Namada 0.20.0 is a minor release addressing several improvements to the PoS system and the ledger stability.

* tag 'v0.20.0': (113 commits)
  Namada 0.20.0
  refator e2e masp tests
  fix tx_transfer
  ci: fix github colon parsing
  changelog: add #1693
  channgelog: add #1738
  [feat]: Moved cli commands common to testing, cli, and sdk out into apps
  ci: pre-download masp parameters
  changelog: add #1733
  pos/epoched: keep 2 past epochs of data by default
  changelog: add #1729
  test/ledger/finalize_block: fix slashing tests
  pos/slash: fix the validator state update to be in sync with set changes
  app/ledger/finalize_block: log block rewards before recording slashes
  test/e2e/slashing: extend the test to discover rewards issues
  pos: error out if validator is not in expected state for rewards
  changelog: add #1717
  test/shell/finalize_block: add some txs to DB commit test
  refactor: rename function
  refactor: rename method
  remove test_invalid_sender
  remove negative check
  ci: clean up
  fix formatting
  don't use flaky sleep
  refactor creation of namada nodes
  make Who clonable
  refactor: use immutable reference
  refactor: use immutable reference
  refactor: remove duplicated code
  test/e2e/slashing: wait for wasm on original validator
  add changelog
  fix changes in finalize_block
  remove vp_token
  changelog: add #1173
  client/rpc: use the new token balance method
  shared/ledger/queries: add token balance client-only method
  changelog: add #1692
  changelog: add #1670
  changelog: add #1667
  [fix]: Fixing errors introduced by merging in main
  [chore]: Incorporating in review comments
  Update core/src/types/uint.rs
  Update apps/src/lib/config/genesis.rs
  [fix]: Fixed the faucet to use uint instead of amount. This makes it portable across different assets
  converts faucet_withdrawal_limit to be correct
  changelog: add #1656
  pos: return sorted validator sets and code re-use for queries
  Expanding and fixing slashes query
  CLI query a validator's state
  query bonded-stake and order
  fix client_connections encoding
  handle errors for unjail-validator tx in the client
  expand and fix e2e test `double_signing_gets_slashed`
  add unjail tx at CLI
  changelog: add #1621
  ci/test/e2e: add new test
  apps: move epoch-sleep client cmd under utils
  changelog: add #1656
  pos: return sorted validator sets and code re-use for queries
  Expanding and fixing slashes query
  CLI query a validator's state
  update pr template
  test/e2e/proposal_submission: wait for proposal to be committed
  test/e2e/double_signing: path for validator copy that keeps logs in CI
  add comments
  fix according to feedback
  refactor: fix formatting
  add changelog
  refactor: simplify code
  refactor: introduce name for magic constant
  add test case
  feat: store total consensus stake; garbage collect validator sets
  query bonded-stake and order
  wait for wasm-precompile before expecting block hash
  changelog: add #1605
  apps: use fd-lock instead of file-lock for cross-platform support
  changelog: add #1695
  deps: update sysinfo to latest 0.29.4
  improve error handling for `set_initial_validators`
  changelog: add #1686
  app/ledger/finalize_block: refactor validator set update for re-use
  app/ledger/init_chain: get genesis validator set using the new fn
  pos: add a function to get genesis validator consensus set for TM
  fix a test
  fix for tx signing
  for clippy
  fix multitoken vp to check the minter
  for clippy
  modify EthBridge VP and EthBridgePool VP for multitoken
  revert unexpected changes
  change eth_bridge balance keys to multitoken keys
  add unit tests
  remove InternalAddress::Minted
  rename
  fix token decoding
  fix balance print
  add multitoken VP file
  change to multitokens
  change multitoken
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants